[FLINK-4573] Fix potential resource leak due to unclosed RandomAccess…#2556
Closed
lw-lin wants to merge 2 commits into
Closed
[FLINK-4573] Fix potential resource leak due to unclosed RandomAccess…#2556lw-lin wants to merge 2 commits into
lw-lin wants to merge 2 commits into
Conversation
…File in TaskManagerLogHandler
zentol
reviewed
Sep 28, 2016
| if (raf != null) { | ||
| raf.close(); | ||
| } | ||
| return; |
Contributor
There was a problem hiding this comment.
let's just re-throw the exception to retain current behavior.
zentol
reviewed
Sep 28, 2016
| } catch (IOException ioe) { | ||
| display(ctx, request, "Displaying TaskManager log failed."); | ||
| LOG.error("Displaying TaskManager log failed.", ioe); | ||
| if (raf != null) { |
Contributor
There was a problem hiding this comment.
this should never be false, as we would otherwise get an NPE and would never enter this block.
Contributor
|
I think this is good to merge... |
Contributor
|
Merging this... |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Sep 29, 2016
…sed RandomAccessFile in TaskManagerLogHandler This closes apache#2556
liuyuzhong
pushed a commit
to liuyuzhong/flink
that referenced
this pull request
Dec 5, 2016
…sed RandomAccessFile in TaskManagerLogHandler This closes apache#2556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…File in TaskManagerLogHandler
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
mvn clean verifyhas been executed successfully locally or a Travis build has passed